clarify nonce/state handling #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jogu
approved these changes
Mar 28, 2024
peppelinux
approved these changes
Mar 28, 2024
c2bo
approved these changes
Mar 29, 2024
awoie
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #39 (hopefully).
I re-read the sections on nonce/state and it seemed that all the necessary information is already in the spec and just needs to be referenced better. let me know if you disagree and want more additional text...
one point that probably needs discussion is this new text "If the response contains multiple Verifiable Presentations which do not contain the same nonce value, the response is rejected."
Do we want something on httponly cookies like this in oidc core? https://openid.net/specs/openid-connect-core-1_0.html#NonceNotes